Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require upnpc as external executable #1036

Merged
merged 1 commit into from
May 16, 2023
Merged

Require upnpc as external executable #1036

merged 1 commit into from
May 16, 2023

Conversation

samuelmanzanera
Copy link
Member

Description

This PR aims to make miniupnp as externalize dependency

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added the system Involve system management label May 16, 2023
@samuelmanzanera samuelmanzanera merged commit f7568b4 into develop May 16, 2023
1 check passed
@samuelmanzanera samuelmanzanera deleted the externalize_upnp branch May 16, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenmoves tenmoves tenmoves approved these changes

@bchamagne bchamagne bchamagne approved these changes

Assignees
No one assigned
Labels
system Involve system management
Projects
Dev Board
Status: Done 🍻
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelmanzanera @tenmoves @bchamagne