Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search io transaction when getting SC calls #1056

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented May 31, 2023

Description

There is an issue when processing the message GetContractCalls. The storage nodes of the smart contract will receive the trigger transactions as io transaction. Hence the node need to search for the transaction in the io part of the DB also.
The current implementation is working with a low number of node as they are all storage node of any transaction

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working smart contracts Involve smart contracts P2P Involve P2P networking labels May 31, 2023
@Neylix Neylix requested a review from bchamagne May 31, 2023 10:18
@Neylix Neylix changed the base branch from develop to 1.1.0 June 1, 2023 08:58
@Neylix Neylix changed the base branch from 1.1.0 to develop June 1, 2023 09:00
@Neylix Neylix merged commit ea41d44 into archethic-foundation:develop Jun 1, 2023
2 checks passed
@Neylix Neylix deleted the Fix_get_contract_calls branch June 1, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2P Involve P2P networking smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants