Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache ChainIndex when bootstrapping #1090

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

bchamagne
Copy link
Member

Description

Do not pre-cache chain index while bootstrapping. Because the LRU cache behind use a GenServer and become a memory problem when there are several millions put requests.

Fixes #1088

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually with logs:

  • restart a node
  • bootstrap a new node

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added this to the 1.1.2 milestone Jun 12, 2023
@bchamagne bchamagne linked an issue Jun 14, 2023 that may be closed by this pull request
@Neylix Neylix merged commit 8f6b5e4 into archethic-foundation:1.1.2 Jun 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CacheIndex memory issue (due to LRU)
2 participants