Refactor P2P.connected? into Connection module #1100
Merged
+83
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchamagne
approved these changes
Jun 15, 2023
| @@ -11,11 +11,20 @@ defmodule Archethic.P2P.Supervisor do | |||
|
|
|||
| use Supervisor | |||
|
|
|||
| @table_name :connection_status | |||
There was a problem hiding this comment.
Maybe you should use a function in the Connection module to give the name of the table.
| def start_link(args \\ []) do | ||
| Supervisor.start_link(__MODULE__, args, name: Archethic.P2PSupervisor) | ||
| end | ||
|
|
||
| def init(_args) do | ||
| # Start an ets table to manage node connection status. | ||
| # This reduce the number of message sent to the Connection GenServer | ||
| if :ets.whereis(@table_name) == :undefined do |
There was a problem hiding this comment.
If we want to be cleaner, the best would be use a dedicated to connection information or status and might manage its own state and lifecycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to be ready for hot reload
Checklist: