Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid parameter in quorum #1121

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 26, 2023

Description

Fixes an issue happening when the quorum needs to resend a request (acceptance resolver not passed or network issue on first nodes). The parameters consistency_level and timeout was inverted in the function call, resulting to timeout of 3ms.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working P2P Involve P2P networking labels Jun 26, 2023
@samuelmanzanera samuelmanzanera merged commit c214e91 into archethic-foundation:develop Jun 26, 2023
2 checks passed
@Neylix Neylix deleted the Fix-Bootsrap-Sync-Timeout branch June 27, 2023 11:20
@bchamagne bchamagne added this to the 1.2.1 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants