Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap sync restart #1122

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 26, 2023

Description

There is an issue in the bootstrap sync restart strategy.
Currently when a repair crash we restart it until 10 tries, but we restart it with the last sync date received in parameter but not the one the failed repair succeeded to reach.
Fixes it by restarting from the last sync date stored in memory

Also fixes an issue where the function bootstrap_sync do not return the expected :error atom

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working bootstrap labels Jun 26, 2023
@samuelmanzanera samuelmanzanera merged commit e155b5e into archethic-foundation:develop Jun 26, 2023
1 check passed
@Neylix Neylix deleted the Fix-bootstrap-sync-restart branch June 27, 2023 11:21
@bchamagne bchamagne added this to the 1.2.1 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants