Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel slot timer before creating a new one #1132

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Cancel slot timer before creating a new one #1132

merged 1 commit into from
Jun 30, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 30, 2023

Description

Fixes an issue where the slot timer could have 2 timer in the same time

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jun 30, 2023
@Neylix Neylix added this to the 1.2.3 milestone Jun 30, 2023
@samuelmanzanera samuelmanzanera merged commit 8a1fdcb into archethic-foundation:release/1.2.3 Jun 30, 2023
2 checks passed
@Neylix Neylix deleted the Fix-slot-timer-multiple-trigger branch June 30, 2023 10:31
samuelmanzanera pushed a commit that referenced this pull request Jul 5, 2023
@Neylix @samuelmanzanera
Cancel slot timer before creating a new one (#1132)
5be6e7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchamagne bchamagne bchamagne approved these changes

Assignees
No one assigned
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Milestone
1.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neylix @bchamagne @samuelmanzanera