Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to forward transaction #1135

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 30, 2023

Description

Fixes an issue where a transaction which is forwarded because validation nodes are not responding or returns an synchronization, can create a loop of death between node if this transaction is also catched by node responsivness.

Now all transaction created by GenServer that also spawn a node responsivness, are not forwarded since node responsivness will do it

Fixes #1134

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working P2P Involve P2P networking mining Involve transaction validation and mining labels Jun 30, 2023
@Neylix Neylix added this to the 1.2.3 milestone Jun 30, 2023
@Neylix Neylix force-pushed the Fix-forward-loop branch 2 times, most recently from 4afe288 to ac890d1 Compare June 30, 2023 11:14
lib/archethic.ex Outdated Show resolved Hide resolved
@Neylix Neylix merged commit bcbe381 into archethic-foundation:release/1.2.3 Jun 30, 2023
2 checks passed
@Neylix Neylix deleted the Fix-forward-loop branch June 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants