Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats adding multiple times same summary #1141

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 3, 2023

Description

Fixes a problem where is was possible that the stats add several times the same beacon summary.

Also enhance the stats file, since only the last summary stats are used we don't need to store each sats for each summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jul 3, 2023
@Neylix Neylix added this to the 1.2.4 milestone Jul 3, 2023
@Neylix Neylix changed the base branch from develop to release/1.2.4 July 3, 2023 09:59
Do not store each summary stats as only last one is used
@samuelmanzanera samuelmanzanera merged commit 255b70b into archethic-foundation:release/1.2.4 Jul 4, 2023
2 checks passed
@Neylix Neylix deleted the filter-stats-info branch July 4, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

None yet

3 participants