Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run election on current node view in self repair #1147

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 4, 2023

Description

Fixes an issue in self repair where a node which is bootstrapping from start run the election based on the P2P view of the latest summary repaired while it should be on the current P2P view of the network (from the latest summary available)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working self repair Involve SelfRepair mechanism labels Jul 4, 2023
@Neylix Neylix added this to the 1.2.4 milestone Jul 4, 2023
@Neylix Neylix changed the base branch from develop to release/1.2.4 July 4, 2023 10:46
@samuelmanzanera samuelmanzanera merged commit f0a72c5 into archethic-foundation:release/1.2.4 Jul 4, 2023
2 checks passed
@Neylix Neylix deleted the Fix-self-repair-node-election branch July 5, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working self repair Involve SelfRepair mechanism
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

None yet

3 participants