Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinmarketcap parser #1151

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Coinmarketcap parser #1151

merged 1 commit into from
Jul 10, 2023

Conversation

bchamagne
Copy link
Member

Description

Some UI changes on CoinMarketCap requires a new parser.
Also write the html in /tmp/ when we fails to parse.
Fixes #1139

  • Lint: use plug

Type of change

  • bug fix

How Has This Been Tested?

tested manually by overriding the body with the problematic one
tested if all extract_fn fails

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the oracle chain Involve OracleChain label Jul 5, 2023
@bchamagne bchamagne changed the base branch from develop to release/1.2.4 July 5, 2023 09:20
@Neylix Neylix added this to the 1.2.4 milestone Jul 7, 2023
@samuelmanzanera samuelmanzanera merged commit 7f748c4 into release/1.2.4 Jul 10, 2023
2 checks passed
@samuelmanzanera samuelmanzanera deleted the 1139-coinmarketcap branch July 10, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oracle chain Involve OracleChain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UcoPrice: CoinMarketCap scraper to adapt
3 participants