Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error in condition execution #1194

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 26, 2023

Description

There is possibility that the code in condition raise an error, in this case the error is not catched and crashes the parent process.

This PR adds a try rescue on the ConditionValidator.valid_conditions? function, same behavior than Interpreter.execute_trigger

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working smart contracts Involve smart contracts labels Jul 26, 2023
@Neylix Neylix force-pushed the Catch-error-in-condition-execution branch from 739efef to 2e88853 Compare July 26, 2023 21:45
@Neylix Neylix merged commit 3da4080 into archethic-foundation:develop Jul 27, 2023
2 checks passed
@Neylix Neylix deleted the Catch-error-in-condition-execution branch July 27, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants