Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String.to_hex now encode any string in hex #1211

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Aug 3, 2023

Description

To not allow developer to interact with binaries, we can let them convert any string in hexadecimal format and concatenate hex representation of string.

Fixes #1160

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added feature New feature request smart contracts Involve smart contracts labels Aug 3, 2023
@Neylix Neylix merged commit dc70bdf into archethic-foundation:develop Aug 8, 2023
2 checks passed
@Neylix Neylix deleted the String.to_hex branch August 8, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenate binaries in the interpreter
2 participants