Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict smart contract functions #1212

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Conversation

herissondev
Copy link
Contributor

@herissondev herissondev commented Aug 3, 2023

Description

  • do not allow function call from pub function
  • private function can only call public function
  • restrict module access to functions

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@herissondev herissondev force-pushed the restrict_smart_contract_functions branch 2 times, most recently from ee4ec8a to f169155 Compare August 7, 2023 14:46
@herissondev herissondev marked this pull request as ready for review August 7, 2023 14:47
Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/tag_test.exs Outdated Show resolved Hide resolved
@herissondev herissondev force-pushed the restrict_smart_contract_functions branch from 9a91516 to 6fc81df Compare August 9, 2023 14:15
@herissondev herissondev requested a review from Neylix August 9, 2023 16:20
@Neylix Neylix mentioned this pull request Aug 10, 2023
2 tasks
@herissondev herissondev force-pushed the restrict_smart_contract_functions branch from 6fc81df to 2cdf3e6 Compare August 10, 2023 09:43
@Neylix Neylix merged commit 56fe049 into develop Aug 10, 2023
2 checks passed
@Neylix Neylix deleted the restrict_smart_contract_functions branch August 10, 2023 09:49
@Neylix Neylix added feature New feature request smart contracts Involve smart contracts labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants