Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor module call and function call in SC #1221

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Aug 17, 2023

Description

Refactor some code in SC to be more understandable and error free

Updated Library module, created new FunctionKeys module

Fixes #1208

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added smart contracts Involve smart contracts quality Improve code quality labels Aug 17, 2023
@Neylix Neylix requested a review from bchamagne August 17, 2023 16:13
lib/archethic/contracts/interpreter.ex Outdated Show resolved Hide resolved
@Neylix Neylix merged commit 1c8b6b2 into archethic-foundation:develop Aug 31, 2023
1 of 2 checks passed
@Neylix Neylix deleted the blacklist-modules branch August 31, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Improve code quality smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart Contracts should use a blacklist instead of a whitelist
2 participants