Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydratingCache now properly handles a timeout of the hydrate function #1237

Merged

Conversation

bchamagne
Copy link
Member

Description

Fix a bug in the HydratingCache:
When the hydrate function took more than 5s, the task was shutdown and the timer was not resetted, resulting in a genserver waiting forever.

Fixes #1154

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the bug Something isn't working label Aug 30, 2023
@bchamagne bchamagne added this to the 1.3.0 milestone Aug 30, 2023
@bchamagne bchamagne merged commit 77acb7e into archethic-foundation:develop Sep 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: hydrating cache not refreshing
2 participants