Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract execution return explicit errors instead of contract_failure #1267

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Sep 8, 2023

Description

Contract execution error used to return always the same error. No more.
This is a first step in direction of #1197

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests + Playground

Screenshot 2023-09-08 at 17-09-21 Archethic Playground

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added smart contracts Involve smart contracts enhancements labels Sep 8, 2023
@bchamagne bchamagne added this to the 1.3.1 milestone Sep 8, 2023
@Neylix Neylix changed the base branch from release/1.3.0 to develop September 12, 2023 14:27
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sooner or later, we have to implement #965 to uniform and reduce strings in validation

@bchamagne bchamagne merged commit 9fcb9e1 into archethic-foundation:develop Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants