-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AEIP-14 State UTXO #1287
Merged
bchamagne
merged 23 commits into
archethic-foundation:develop
from
bchamagne:1217-stateful-utxo
Nov 7, 2023
Merged
AEIP-14 State UTXO #1287
bchamagne
merged 23 commits into
archethic-foundation:develop
from
bchamagne:1217-stateful-utxo
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d8786b
to
1a39000
Compare
1a39000
to
138c867
Compare
…re was no next_tx
926e68b
to
f267dd0
Compare
I've merged and retested 👍 |
f267dd0
to
aeebbeb
Compare
Neylix
requested changes
Nov 3, 2023
lib/archethic/transaction_chain/transaction/validation_stamp/ledger_operations.ex
Outdated
Show resolved
Hide resolved
|
||
case result do | ||
%Contract.Result.Success{next_tx: expected_next_tx} -> | ||
{Transaction.same_payload?( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also ensure the resulting state is the same. As if it's not we will have an invalid contract execution which is more accurate than an invalid unspent outputs
Neylix
reviewed
Nov 3, 2023
7506a34
to
bf1e644
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AEIP
DB
Involve database
feature
New feature request
mining
Involve transaction validation and mining
replication
smart contracts
Involve smart contracts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new kind of UTXO (Unspent Output) to store the state of smart contract.
See https://github.com/archethic-foundation/aeip/blob/main/AEIP-14.md
Fixes #1217
Type of change
How Has This Been Tested?
Many unit tests and this scenario:
(the authorized key is the StorageNoncePublicKey)
Tested with 1 node
Tested with 3 nodes
Checklist: