Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipients arguments encoding #1304

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

samuelmanzanera
Copy link
Member

Description

This PR aims to resolve an issue of inconsistency with JSON encoding, particularly with decimals.

Hence, it introduces a typed encoding approach of arguments and also use a different algorithm for the previous signature verification and the storage.

Previous signature tx's serialization happens with bit encoded on 1 byte (to simplify SDK and client integration), while for storage we can encode into 1 bit (Erlang allow us to optimize bitstring encoding easily)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested while developing the new version of the JS SDK.
I was able to trigger contracts with named action.

@Neylix Neylix force-pushed the add_recipients_arguments_encoding branch from cb1dde4 to a717e61 Compare October 17, 2023 18:16
@Neylix Neylix changed the base branch from develop to release/1.3.1 October 17, 2023 18:17
@samuelmanzanera
Copy link
Member Author

👍

@Neylix Neylix force-pushed the add_recipients_arguments_encoding branch from a717e61 to 22deef0 Compare October 18, 2023 07:23
@Neylix Neylix merged commit 8bcceeb into release/1.3.1 Oct 18, 2023
2 checks passed
@Neylix Neylix deleted the add_recipients_arguments_encoding branch October 18, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working serialization Involve message serialization transaction Involve transactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants