Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinmarketcap provider duplication #1329

Merged

Conversation

bchamagne
Copy link
Member

Description

The CoinMarketCap url will soon change from /uniris to /archethic.
This PR handles both so the transition is smooth

Fixes #1328

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested the release upgrade, the 2 new providers take over the old one.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the bug Something isn't working label Nov 17, 2023
@bchamagne bchamagne changed the base branch from release/1.3.2 to release/1.3.3 November 17, 2023 15:33
@bchamagne bchamagne merged commit 45dca8a into archethic-foundation:release/1.3.3 Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant