New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when there are 10 txs in last page #1362

Merged

Neylix merged 1 commit into archethic-foundation:develop from bchamagne:chain-reader-bug

Jan 5, 2024

Member

bchamagne commented Jan 5, 2024

Description

When exploring a chain that have a multiple of ten transactions, the last page could not load and crashed.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit-tests and manual testing

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          Fix bug when there are 10 txs in last page

65ef015

bchamagne added the bug label

bchamagne added this to the 1.4.4 milestone

Neylix approved these changes

View reviewed changes

Neylix merged commit f9cb2ca into archethic-foundation:develop

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment