Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in Notify workflow #1369

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Jan 8, 2024

Description

The message for NotifyPreviousChain uses an index to specify the node. The index was based on authorized_and_available_nodes on sender and on the chain_storage_nodes on the receiver end.

Fixes #1331

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the bug Something isn't working label Jan 8, 2024
…be retrieved because it did not use the same reference list
@samuelmanzanera samuelmanzanera added mining Involve transaction validation and mining election labels Jan 10, 2024
@samuelmanzanera samuelmanzanera merged commit 1d9dfa2 into archethic-foundation:develop Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working election mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send_message used with a nil node
3 participants