Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope assignation returns assigned value #1386

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 16, 2024

Description

Fixes an issue in smart contract language where it could be possible for a user to have an atom in a variable.
When assigning a value to a variable, we call Scope.write_cascade, this function was returning :ok. The problem was that we could create a function where the last statement is a assignation, and so the function returns :ok

action ... do
  my_var = bad_return()
  log(my_var) 
  # :ok
end

fun bad_return() do
  # Assignation returns :ok
  var = "toto"
end

The fix is to have the same behavior than elixir, the assignation return the assigned value

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Create a simple contract with a function that assign a value in it's last statement

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working smart contracts Involve smart contracts labels Jan 16, 2024
@Neylix Neylix added this to the 1.4.5 milestone Jan 16, 2024
@samuelmanzanera samuelmanzanera merged commit f4623fe into archethic-foundation:develop Jan 17, 2024
2 checks passed
@Neylix Neylix deleted the Fix-scope-assignation branch January 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants