Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #1395

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 25, 2024

Description

Fixes some bugs and improve little things

  • Fixed telemetry error => buckets expected nb of summaries that was never calculated
  • Delete unused functions
  • Add max concurrency to a task async as all the response in the workflow should be retrieved fast
  • Fix a flaky test
  • Update function P2P.broadcast_message as this function should be used as "fire and forget" but it was waiting for all message to be sent and to receive the response.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working enhancements labels Jan 25, 2024
@samuelmanzanera samuelmanzanera merged commit c2c5352 into archethic-foundation:develop Jan 26, 2024
2 checks passed
@Neylix Neylix deleted the Improvements branch January 26, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants