Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress the transaction code on serialization #1396

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

bchamagne
Copy link
Member

Description

  • Compress code when serializing it (network & db)
  • Check code size on compressed code

Fixes #1299

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with following scenarios:

  • an existing contract is triggered in the newer version
  • a new contract is triggered
  • explorer can read transactions with zipped or unzipped code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added feature New feature request P2P Involve P2P networking DB Involve database labels Jan 26, 2024
@bchamagne bchamagne marked this pull request as ready for review January 26, 2024 14:59
@bchamagne bchamagne added this to the 1.4.7 milestone Jan 26, 2024
@Neylix Neylix merged commit 5eecb27 into archethic-foundation:develop Jan 26, 2024
1 of 2 checks passed
@Neylix Neylix added enhancements and removed feature New feature request labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB Involve database enhancements P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database should compress the code before writing it in file system
3 participants