Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better conflict/acceptance resolver #1400

Conversation

bchamagne
Copy link
Member

Description

  • download_transaction check for the tx's integrity directly in the acceptance_resolver
  • fetch_transaction's conflict_resolver was naive and accepted the first non-error result

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working P2P Involve P2P networking labels Jan 31, 2024
@bchamagne bchamagne marked this pull request as ready for review January 31, 2024 10:57
@samuelmanzanera samuelmanzanera added enhancements self repair Involve SelfRepair mechanism and removed bug Something isn't working labels Jan 31, 2024
@Neylix Neylix merged commit 961a65f into archethic-foundation:develop Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements P2P Involve P2P networking self repair Involve SelfRepair mechanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants