Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consumed input #1415

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 2, 2024

Description

Update unspent output to match consumed inputs during AEIP 21 phase 1 (do not recreate an utxo if it is the same a an previous one)

Optimize consumed inputs to not consume an UTXO that would be consolidated alone

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working enhancements labels Feb 2, 2024
end
end

defp optimize_inputs_to_consume(inputs, _, _) when length(inputs) == 1, do: inputs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: you may pattern match [input]

Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a resupply transaction:
Capture d’écran 2024-02-05 à 11 49 40

previous utxo did not change address.

there are 2 consumed inputs:

  • uco (because of the fee)
  • the minted supply (from=burn address)

Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neylix Neylix merged commit 63047ad into archethic-foundation:enhance_utxo_with_consumed_inputs Feb 5, 2024
1 check passed
@Neylix Neylix deleted the Improve-consumed-input branch February 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants