Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utxo sort on state without timestamp #1440

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 21, 2024

Description

Fixes an issue where utxo of type state can have a nil timestamp, and this crashes a DateTime.compare

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added the bug Something isn't working label Feb 21, 2024
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neylix Neylix merged commit 48e2e41 into archethic-foundation:develop Feb 23, 2024
2 checks passed
@Neylix Neylix deleted the Fix-utxo-sort branch February 23, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants