New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TransactionInput.set_spent to compare only using from and type #1450

Merged

Neylix merged 1 commit into develop from fix_set_spent_traansaction_input

Mar 8, 2024

Member

samuelmanzanera commented Mar 8, 2024

Description

Fix comparison with inputs which have different timestamp due to different serialization

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          Fix TransactionInput.set_spent to compare only using from and type

samuelmanzanera added the bug label

samuelmanzanera added this to the 1.5.0-rc2 milestone

Neylix approved these changes

View reviewed changes

Neylix merged commit ae07c88 into develop

1 check failed

Neylix deleted the fix_set_spent_traansaction_input branch

March 8, 2024 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment