Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap interpreter execution in a task to isolate calls #1463

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

samuelmanzanera
Copy link
Member

Description

Fix smart contract execution to be run inside a task to avoid intepreter's process limitations

This way the code's execution is isolated and multiple run from condition, actions and after contract renewal will be independent of
the worker being or not in the same process.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working smart contracts Involve smart contracts labels Mar 14, 2024
lib/archethic/contracts.ex Show resolved Hide resolved
@samuelmanzanera
Copy link
Member Author

👍

@Neylix Neylix merged commit 512b240 into develop Mar 15, 2024
1 check failed
@Neylix Neylix deleted the add_contract_execution_in_process branch March 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants