Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateSmartContractCall better conflict resolution #1498

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

bchamagne
Copy link
Member

Description

Take into account the latest_validation_time when resolving conflicts on contract calls execution.
I based this PR on #1343. Please ignore all commits but last 3.
Fixes #1485

Type of change

  • Enhancement

How Has This Been Tested?

unit-tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added smart contracts Involve smart contracts mining Involve transaction validation and mining enhancements labels Apr 10, 2024
@bchamagne bchamagne added this to the 1.5.1 milestone Apr 10, 2024
@Neylix Neylix merged commit 9238407 into archethic-foundation:develop Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements mining Involve transaction validation and mining smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Validate Smart Contract Call conflict resolver
2 participants