Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slippage acceptance for fee's validation #1515

Merged
merged 1 commit into from
May 22, 2024

Conversation

samuelmanzanera
Copy link
Member

Description

Add splipage acceptance for tx's fee validation of 3%

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working mining Involve transaction validation and mining Fee labels May 17, 2024
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good, but the same control is missing in the TransactionValidator module.
I suggest to create a function like Fee.valid_variation? to unify both workflow

@Neylix Neylix merged commit 8974ca9 into develop May 22, 2024
2 checks passed
@Neylix Neylix deleted the splipage_tx_fee_validation branch May 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fee mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants