-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node worldmap in explorer #238
Add node worldmap in explorer #238
Conversation
For the UI, what do you think of:
Something more graphical should be great. |
Thanks for reply ! Using echarts is a good idea as it is already imported and used in telemetry. However using points on the map is not interesting because the range of coordinates is to large. Here the worldmap with all ranges displayed : So we cannot have precise point on the map, unless if we get the exact coordinates from nodes instead of getting a range using geo patch. In all case, I think that displaying the range is a good idea as it is an important variable for the ARCH consensus. What do you think about getting node exact coordinates and grouping them with a range of +-1 and so have good precision to diplay them as a point on the map like in your exemple ? |
Hello. Also if there are too many points we can aggregate or if for UI clarity it will not render nicely, we can keep two digits and show popup with the number of nodes inside. |
Hi ! Correct me if I'm wrong but I think that each digit do not subdivise by 16 the possible range, the first one yes, but the 2 others only subdivise by 4 : So with that said, we can have only 256 geo patch (16 * 4 * 4). If I'm right, the final subdivision looks like the map I presented in my last comment (16 by 16 subdivisions) |
Hello. |
Hi @samuel-uniris @I-Archer-Zero |
Related to #253 |
How to test :
|
* Implement algorithm to retrieve coordinates * add world map page on the explorer * Add possibility to show authorized and pending node
Description
Working on issue #225
Implement first task :
I noticed that some coordinates cannot compute a geo patch. For exemple when longitude is equal to -45, sdc and tdc are equal to 1 or -1 and then are not in range for the index_patch function
Test are just on 4 geo patch, but I tested all and it works fine (cannot test all in geo_patch_test cause compute_patch is private)
I'll work soon on second task to add map on the explorer, I think to use Leaflet to display the map