Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add on_chain_wallet origin id #251

Merged
2 commits merged into from
Mar 9, 2022

Conversation

blackode
Copy link
Contributor

@blackode blackode commented Mar 8, 2022

Description

In this change, we are adding a new origin id on_chain_wallet with value 0 and converted software from 0 to 1 and tpm has been converted from 1 to 2.

The new origin ids are as follows

on_chain_wallet: 0
software: 1
tpm: 2

Fixes #162

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@blackode blackode requested a review from a user March 8, 2022 08:45
@ghost ghost changed the base branch from master to develop March 8, 2022 09:32
@blackode blackode changed the title [WIP] [Feature] Add on_chain_wallet origin id [Feature] Add on_chain_wallet origin id Mar 9, 2022
@blackode blackode added the feature New feature request label Mar 9, 2022
@ghost ghost merged commit 1d04a66 into develop Mar 9, 2022
@ghost ghost deleted the 162-add-on_chain_wallet-origin-id branch March 9, 2022 08:12
ghost pushed a commit to archethic-foundation/libjs that referenced this pull request Mar 9, 2022
ghost pushed a commit to archethic-foundation/libjs that referenced this pull request Mar 9, 2022
ghost pushed a commit that referenced this pull request Mar 24, 2022
Closes #162 
Co-authored-by: Samuel <samuel@uniris.io>
@ghost ghost mentioned this pull request Apr 27, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant