-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http port in node details #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Mar 17, 2022
Also it would be great to add, in the metrics collector for polling, the reference to the HTTP port.
|
Do you need more details on this one ? |
ghost
reviewed
Mar 18, 2022
ghost
reviewed
Mar 18, 2022
ghost
pushed a commit
that referenced
this pull request
Mar 24, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, there isn't the
http_port
information in the nodecontent
section. So, added thehttp_port
information in the node structure.Code Changes
New Node struct
@discovery_table
relatedMemTable
. Here, we used the index to update the fields inets
tables, as we introduced a new field the new indexes got updated to relevant fields.[{ip_address, http_port()}]
before it is[ip_address]
Fixes #243
Type of change
How Has This Been Tested?
As this is related to node struct, I have updated the relevant test cases to use the new node struct as a result a lot of existing test cases were failed. So, update the relevant test units with the new node struct and see that all test cases are passed.
http_port
http_port
part while serializing and de-serializing the nodehttp_port
informationhttp_port
Checklist: