Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions #263

Merged
11 commits merged into from
Mar 18, 2022
Merged

Fix regressions #263

11 commits merged into from
Mar 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2022

Description

Previous commits included some regression regarding:

  • node election
  • new transaction address design (faucet configuration)
  • beacon chain slot transaction attestations appending

Fixes #254
Fixes #255

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Running multiple nodes should not raise errors regarding replication attestation
  • Running multiple nodes should not raise errors in self repair due to invalid node election
  • Send a transaction when new authorized nodes should not raise errors due to node election
  • Running multiple node with docker-compose (same entry time)
  • Running multiple node with using: iex (delayed entry time)
  • Running non-regression tool: docker-compose up validate

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Samuel added 9 commits March 15, 2022 14:03
The authorized nodes will ensure the replication attestation is performed with some level of confidence and will reduce the time to wait the replication attestations.
When a single transaction is written to the database, it checks if there are previous transaction in a chain, if so, the previous chain is linked to the new transaction
This was linked to issues Mar 17, 2022
@ghost ghost added P2P Involve P2P networking crypto Involve cryptography beacon chain Involve BeaconChain self repair Involve SelfRepair mechanism core team Assigned to the core team bug Something isn't working labels Mar 17, 2022
@ghost ghost requested review from blackode and imnik11 March 17, 2022 21:03
Copy link
Contributor

@blackode blackode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read PR description

  • Read AC

  • Pulled branch, manually tested, verified AC are met

  • Reviewed the code

  • Running multiple nodes should not raise errors regarding replication attestation

  • Running multiple nodes should not raise errors in self-repair due to invalid node election

  • Send a transaction when new authorized nodes should not raise errors due to node election

  • Running multiple node with docker-compose (same entry time)

  • Running multiple node with using: iex (delayed entry time)

  • Running non-regression tool: docker-compose up validate

@ghost ghost merged commit 380b8f5 into develop Mar 18, 2022
@ghost ghost deleted the fix_regressions branch March 18, 2022 13:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working core team Assigned to the core team crypto Involve cryptography P2P Involve P2P networking self repair Involve SelfRepair mechanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid proof of election Invalid transaction attestation
1 participant