Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the shared secret keystore loading #279

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2022

Description

Because of the new DB design, the order of transaction is not desc but
asc.

So the loader had to be changed, to load the latest transaction
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

When you run the node after few times, when you restart it should have error of proof_of_election, due to an invalid last shared secrets tx.
Also unit tests have been update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Because of the new DB design, the order of transaction is not desc but
asc.

So the loader had to be changed, to load the latest transaction
@ghost ghost added bug Something isn't working crypto Involve cryptography DB Involve database shared secrets Involve SharedSecrets labels Apr 8, 2022
@ghost ghost assigned imnik11 Apr 8, 2022
@imnik11 imnik11 merged commit 6a408ee into develop Apr 13, 2022
@imnik11 imnik11 deleted the fix_shared_secrets_keystore_loader branch April 13, 2022 09:11
@ghost ghost mentioned this pull request Apr 27, 2022
ghost pushed a commit that referenced this pull request May 6, 2022
Because of the new DB design, the order of transaction is not desc but
asc.

So the loader had to be changed, to load the latest transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crypto Involve cryptography DB Involve database shared secrets Involve SharedSecrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant