Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DB decoding of nested list #284

Merged
1 commit merged into from
Apr 21, 2022
Merged

Fix DB decoding of nested list #284

1 commit merged into from
Apr 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2022 •
edited by ghost
Loading

Description

Fix problem of decoding of nested list fields due to a problem of range

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Go the /api/graphiql, and run the transactions query with list of fields like:

  • crossValidationStamps
  • ownerships
  • unspentOutputs
  • transactionMovements
  • recipients

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added bug Something isn't working DB Involve database labels Apr 21, 2022
@ghost ghost requested a review from blackode April 21, 2022 07:34
blackode
blackode approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@blackode blackode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 4132c30 into develop Apr 21, 2022
@ghost ghost deleted the fix_db_decoding_list branch April 21, 2022 07:44
@ghost ghost mentioned this pull request Apr 27, 2022
Merged
ghost pushed a commit that referenced this pull request May 6, 2022
Fix DB decoding of nested list (#284)
7abb6b7
@ghost ghost mentioned this pull request May 13, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working DB Involve database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@blackode