Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests on CI with more determinism #290

Merged
7 commits merged into from
Apr 28, 2022
Merged

Fix tests on CI with more determinism #290

7 commits merged into from
Apr 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2022 •
edited by ghost
Loading

Description

Avoid the database tests to be async, causing some issue when the ChainIndex is started multiple in async mode.
Improve date management with more determinism in the tests.

Refer to #285

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • mix test pass with multiple seeds
  • CI should pass as well for multiple runs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost self-assigned this Apr 27, 2022
@ghost ghost changed the title Make the DB test non-async to fix CI Fix tests on CI with more determinism Apr 27, 2022
@ghost ghost requested a review from prix-uniris April 27, 2022 10:08
@ghost ghost added testing Improve testing feature New feature request labels Apr 27, 2022
@ghost ghost force-pushed the fix_async_db_test branch from fedcb43 to be25168 Compare April 28, 2022 17:36
@ghost ghost merged commit 906ff03 into develop Apr 28, 2022
@ghost ghost deleted the fix_async_db_test branch April 28, 2022 19:54
@ghost ghost mentioned this pull request Apr 29, 2022
Open
ghost pushed a commit that referenced this pull request May 6, 2022
Fix tests on CI with more determinism (#290)
64ddc62 
* Make the DB test non-async to fix CI

* Remove match of the GenServer startup return for KVs

* Make tests with date more deterministic

* Unify test setup

* Fix race condition in time based tests

* Let validation nodes notify previous storage nodes

* Disable bloom filters causing issues as false negatives
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prix-uniris prix-uniris Awaiting requested review from prix-uniris

Assignees
No one assigned
Labels
feature New feature request testing Improve testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
0 participants