Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin key api #292

Merged
14 commits merged into from
May 3, 2022
Merged

Origin key api #292

14 commits merged into from
May 3, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Apr 29, 2022

Description

A new origin_key API is available. It permit to get the encrypted secret and encrypted secret key of the origin shared secrets encrypted by the public key passed threw request params.

Fixes #158

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test files
  • Launch the netwrok which create a random origin shared secrets encrypted by the hardcoded origin public key in config file, used this public key with the API and get the JSON content expected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix requested a review from a user April 29, 2022 07:35
@Neylix Neylix added crypto Involve cryptography API Involve API facing user shared secrets Involve SharedSecrets labels Apr 29, 2022
@Neylix
Copy link
Member Author

Neylix commented Apr 29, 2022

For test and development, I used code added in #288
last commit is for this implementation (782d403)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR 👍, just few comments to improve it

lib/archethic_web/router.ex Outdated Show resolved Hide resolved
@Neylix Neylix requested a review from a user May 2, 2022 07:13
lib/archethic_web/router.ex Outdated Show resolved Hide resolved
@ghost ghost added the feature New feature request label May 3, 2022
@ghost ghost merged commit 6081183 into archethic-foundation:develop May 3, 2022
@Neylix Neylix deleted the Origin-key-API branch May 4, 2022 06:43
ghost pushed a commit that referenced this pull request May 6, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user crypto Involve cryptography feature New feature request shared secrets Involve SharedSecrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant