Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunk authorized nodes issue #316

Merged
2 commits merged into from
May 12, 2022
Merged

Fix chunk authorized nodes issue #316

2 commits merged into from
May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022 •
edited by ghost
Loading

Description

This PR fixes the invalid authorization nodes list when validation are churning (leave and join)

Fixes #315

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Start a node: iex -S mix
  • Start another node: ARCHETHIC_CRYPTO_SEED="node2" ARCHETHIC_HTTP_PORT=4003 ARCHETHIC_P2P_PORT=3003 iex -S mix
  • Wait the second node to become authorized node
  • Stop the second node
  • Restart the second node

Then we should not have error regarding election of nodes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Samuel added 2 commits May 12, 2022 15:39
Fix load of last tx in P2P bootstrapping
8cd9ffb 
From the new DB implementation, the ordering of transaction have changed
causing this issue. Transactions are retrived in the ascending order instead
of descending
Better handling of storage nonce loading
901b809 
Storage nonce was stored on Base.encode16 but the reading was not
parsed.
But there is not need to encode in hex as we can store into binary
@ghost ghost added bug Something isn't working P2P Involve P2P networking crypto Involve cryptography labels May 12, 2022
@ghost ghost requested a review from Neylix May 12, 2022 13:56
@ghost ghost merged commit 7246348 into develop May 12, 2022
@ghost ghost deleted the fix_chunk_authorized_nodes_issue branch May 12, 2022 15:13
This was referenced Jun 27, 2022
Open
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working crypto Involve cryptography P2P Involve P2P networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Neylix