Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves Add telemetry for embedded database#327 #334

Merged
2 commits merged into from
May 24, 2022
Merged

Resolves Add telemetry for embedded database#327 #334

2 commits merged into from
May 24, 2022

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented May 20, 2022

Description

Add telemetry at Methods under

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • visit localhost/metrics to see exported telemetry

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 requested a review from blackode May 20, 2022 13:39
@apoorv-2204 apoorv-2204 changed the title add telemetry Resolves Add telemetry for embedded database#327 May 20, 2022
@apoorv-2204 apoorv-2204 marked this pull request as ready for review May 23, 2022 11:40
Copy link
Contributor

@blackode blackode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read PR description
  • Read AC
  • Pulled branch, manually tested, verified AC are met
  • Reviewed the code
  • Metrics shown /metrics
    image

@blackode blackode self-requested a review May 24, 2022 09:16
@ghost ghost added feature New feature request DB Involve database labels May 24, 2022
@ghost ghost merged commit cbff7e7 into archethic-foundation:develop May 24, 2022
@apoorv-2204 apoorv-2204 deleted the add_telemetry_in_embedded_storage#327 branch June 3, 2022 14:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB Involve database feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants