Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New api for web hosting #337

Merged
9 commits merged into from
May 30, 2022
Merged

New api for web hosting #337

9 commits merged into from
May 30, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented May 23, 2022

Description

This PR implement a new API for web_hosting. This API transform a transaction content in JSON format to a web like storage, i.e folders and file.
So it is now possible to create transaction with JSON schema which provide functionnality to host a classical or complex website.

Fixes #333

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with some JSON data in web browser, it returns good content and good content-type for browser to understand what kind of data it is.
All tests are in test file, all functions are tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added feature New feature request API Involve API facing user labels May 23, 2022
@Neylix Neylix requested review from a user and imnik11 May 23, 2022 14:35
@Neylix
Fix json path for more than 2 depth path
2751162
@Neylix
Update encodage to force base64 in JSON
e4aca76 
All file are encoded in base64 inside JSON content
The encodage value is the encodage done before base64
(corresponding to brower content-encoding)
@Neylix
Fix encodage error
9e1e87f
@Neylix Neylix marked this pull request as draft May 26, 2022 09:32
@Neylix Neylix marked this pull request as ready for review May 30, 2022 07:37
@ghost ghost merged commit ed208ea into archethic-foundation:develop May 30, 2022
@Neylix Neylix deleted the New-API-for-web-hosting branch June 1, 2022 06:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnik11 imnik11 imnik11 approved these changes

Assignees
No one assigned
Labels
API Involve API facing user feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neylix @imnik11