Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transaction value fee to a fixed one (base fee) #368

Merged
6 commits merged into from
Jun 9, 2022

Conversation

blackode
Copy link
Contributor

@blackode blackode commented Jun 8, 2022

Description

The transaction fee value for oracle transactions have been set with 0.01/uco_price_in_usd

Fixes #349

Type of change

  • New feature (non-breaking change which adds functionality)

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

  • Any dependent changes have been merged and published in downstream modules

@blackode blackode requested a review from a user June 8, 2022 11:39
lib/archethic/mining/fee.ex Outdated Show resolved Hide resolved
@blackode blackode force-pushed the 349-change-tx-fee-with-base-fee branch from 3c24793 to af729f1 Compare June 9, 2022 05:47
lib/archethic/mining/fee.ex Outdated Show resolved Hide resolved
test/archethic/mining/fee_test.exs Show resolved Hide resolved
@ghost ghost changed the title Transaction fee value cost for oracle transactions Change transaction value fee to a fixed one (base fee) Jun 9, 2022
@ghost ghost merged commit d551e8c into develop Jun 9, 2022
@ghost ghost deleted the 349-change-tx-fee-with-base-fee branch June 9, 2022 15:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant