-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement read quorum #369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
implement_read_quorum
branch
4 times, most recently
from
June 9, 2022 07:59
dc3e16b
to
86c07c3
Compare
ghost
self-assigned this
Jun 9, 2022
ghost
changed the title
Implement read quorum
Add P2P atomic reads
Jun 9, 2022
ghost
force-pushed
the
implement_read_quorum
branch
2 times, most recently
from
June 13, 2022 08:25
19a71ec
to
ec90345
Compare
ghost
changed the title
Add P2P atomic reads
Implement read quorum
Jun 13, 2022
ghost
marked this pull request as ready for review
June 13, 2022 08:37
ghost
requested a review
from Neylix
June 13, 2022 08:37
ghost
force-pushed
the
implement_read_quorum
branch
from
June 13, 2022 20:00
ec90345
to
bdb8f49
Compare
Neylix
requested changes
Jun 14, 2022
ghost
force-pushed
the
implement_read_quorum
branch
from
June 14, 2022 09:15
bdb8f49
to
3fdfc53
Compare
Neylix
approved these changes
Jun 14, 2022
Define a new function in the P2P module to handle message sending to multiple nodes and handle reads using monotonic quorum reads. The closest node is used to fetch the first results and others results are fetched from a subgroup defined by a consistency level argument. The results should be newer than the prior one, based on some conflict resolver function passsed as argument.
ghost
force-pushed
the
implement_read_quorum
branch
from
June 14, 2022 20:05
3fdfc53
to
f2dc84e
Compare
ghost
deleted the
implement_read_quorum
branch
June 14, 2022 20:21
ghost
mentioned this pull request
Jun 27, 2022
Open
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes P2P calls more consistent by requesting multiple nodes using read quorum.
It manages the conflict resolution through custom function.
This should bring more consistency by reducing stale data.
Fixes #332
Type of change
Please delete options that are not relevant.
Checklist: