Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 0 String Length Check on address_type.ex before decoding. #394

Merged
1 commit merged into from
Jun 21, 2022

Conversation

prix-uniris
Copy link
Contributor

Description

At the moment, when an empty string is provided to graphql_schema, It was causing an error in ae-node side since, "" can be decoded but it's not a valid address which is not check in Crypto.valid_address/1. To solve this, added a 0 string length check before decoding the string and progressing forward.

Fixes # (issue)
#362

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added a test in graphql_schema_test.exs

  • test "should return error on 0 length address argument"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@prix-uniris prix-uniris requested a review from a user June 21, 2022 16:58
@ghost ghost merged commit e986567 into archethic-foundation:develop Jun 21, 2022
@ghost ghost added the bug Something isn't working label Jun 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant