Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB crashes when transaction chain not found #398 #428

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Jul 5, 2022

Description

If paging address does not exits, catch the error.

Fixes # (#398)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manual Api testing
  • Add test cases

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented Jul 6, 2022

Returned empty List during : invalid paging address

Sender: abc -> 000066da0fab158ebdd8f4a5a0a543413a01cf7f69c8e64c20f49e9c3bd06d04163d
receiver: abcd -> 000000c1c7d25944e792f5476e3323d43a9e3431e38f5b15fd61c9c541a63b46c49c
add 16 transaction movements abc -> abcd
screenshot 1: 16 transactions
1

screenshot 2: unknown Paging address results in empty list
3

@apoorv-2204 apoorv-2204 self-assigned this Jul 6, 2022
@apoorv-2204 apoorv-2204 added bug Something isn't working DB Involve database API Involve API facing user core team Assigned to the core team labels Jul 6, 2022
@apoorv-2204 apoorv-2204 requested a review from Neylix July 6, 2022 10:02
@apoorv-2204 apoorv-2204 changed the title [Testing]DB crashes when transaction chain not found #398 DB crashes when transaction chain not found #398 Jul 6, 2022
@Neylix Neylix merged commit f1ab364 into archethic-foundation:develop Jul 6, 2022
@apoorv-2204 apoorv-2204 deleted the db_crash_398 branch July 26, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user bug Something isn't working core team Assigned to the core team DB Involve database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants