Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slot time error on bootstrap #431

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 6, 2022

Description

If a node start just before a slot time and finish its bootstrap after the slot time, the first slot created will have a wrong slot_time ad causes this error during beacon summary :

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Add a Process.sleep() before starting bootstrap and run a node before a slot time (every 10 sec in dev mode).
It now do not fall in error during the beacon summary

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jul 6, 2022
@Neylix Neylix changed the base branch from master to develop July 6, 2022 16:59
@Neylix Neylix merged commit 6ac8d25 into archethic-foundation:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant