Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple pub sub causing crash due to new replication attestations #432

Merged

Conversation

imnik11
Copy link
Contributor

@imnik11 imnik11 commented Jul 6, 2022

Description

we were using same pub sub for replication attestation during transaction validation which caused crash due to beacon explorer was also using the same. Now we added a separate PubSub for beacon explorer to get the transaction attestations and push it to UI

Fixes #429

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run 3 nodes and checked the logs, Now I don't get a lot of logger msg showing same info. And the transaction duplication is also fixed in beacon explorer

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix
Copy link
Member

Neylix commented Jul 8, 2022

Nice catch !

@Neylix Neylix merged commit 7b09579 into archethic-foundation:develop Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants