Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client connection when receive a request #435

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 8, 2022

Description

Sometimes when a node disconnect and reconnect, the state of connection is not set to :connected before a node try to send message to it and so message falls in error because the node thinks that the other node is not connected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run 2 nodes, disconnect one and reconnect it just after, we should not see message Cannot send message ...... :closed after the node is reconnected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working P2P Involve P2P networking networking Involve networking labels Jul 8, 2022
@Neylix Neylix requested a review from imnik11 July 8, 2022 07:57
@Neylix Neylix force-pushed the Improve-P2P-communication branch from 82cc373 to 1e52172 Compare July 8, 2022 08:00
@Neylix Neylix merged commit 5321bff into archethic-foundation:develop Jul 8, 2022
@Neylix Neylix deleted the Improve-P2P-communication branch July 8, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working networking Involve networking P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants